Adds is_null function to RowAccessor#9979
Open
choubacha wants to merge 3 commits into
Open
Conversation
When dealing with parquet files directly, having a built in option for checking for nulls is useful when reading the rows out of the file. This function allows gating calls to the other accessors so that they can be mapped to None instead of relying on errors or accessing the field vec itself. Fixes apache#8076
Author
|
Whoops, fixed the implementation and eliminated the Result as it's not actually needed. |
Author
|
Also noticing that these accessor functions appear to panic if you go out of bounds. I'd like to update those index operations with |
choubacha
commented
May 21, 2026
| if let Some((_, v)) = self.fields.get(i) { | ||
| v | ||
| } else { | ||
| &"<IndexOutOfBound>" |
Author
There was a problem hiding this comment.
Unsure if this should be something different so if you have another recommendation feel free to weigh in.
alamb
approved these changes
May 21, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thank you @choubacha
| if let Some((_, v)) = self.fields.get(i) { | ||
| v | ||
| } else { | ||
| &"<IndexOutOfBound>" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When dealing with parquet files directly, having a built in option for checking for nulls is useful when reading the rows out of the file. This function allows gating calls to the other accessors so that they can be mapped to None instead of relying on errors or accessing the field vec itself.
Are these changes tested?
Yes, a test was added.
Are there any user-facing changes?
This does add to the Row api. The trait function has a documentation block.